Modernize tests #377
Merged
Modernize tests #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in "No address added out of total 1 resolved"
|
Can you also add Node 20 and 22 into Github workflow, and remove 16? |
…ved' - try with serial: true
Done. |
Merged
|
Thanks for merging. I noticed that tests sometimes still fail with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought some random test failures discussed in #375 might have been caused by the relatively old ava version, so I updated it to the latest version.
ava v4 removed test.cb, so I rewrote those tests to use promises and async/await.
After those changes tests sometimes still failed with
No address added out of total 1 resolved. Probably because ava runs test files in parallel by default which could cause random port clashes. To solve this, this sets"concurrency": 1which essentially disables running of tests in parallel processes (see ava options).If using util.promisify is preferred over manually creating promises for method calls, I'm happy to change this.