Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes clang build #80

Merged
merged 5 commits into from
Sep 28, 2023
Merged

Fixes clang build #80

merged 5 commits into from
Sep 28, 2023

Conversation

francocipollone
Copy link
Collaborator

@francocipollone francocipollone commented Sep 26, 2023 •
edited
Loading

🦟 Bug fix

Fixes #

Summary

Fixes scan build run and clang compilation.

/usr/include/pybind11/pybind11.h:1008:9: error: no matching function for call to 'operator delete'
        ::operator delete(p, s, std::align_val_t(a));

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if it affects the public API)

@francocipollone
Fixes scan build CI.
bd8e527 
Signed-off-by: Franco Cipollone <franco.c@ekumenlabs.com>
@francocipollone francocipollone added do-clang-test Runs clang and sanitizers builds do-static-analyzer-test Runs scan-build workflow labels Sep 26, 2023
@francocipollone
Include eol distros.
824d972 
Signed-off-by: Franco Cipollone <franco.c@ekumenlabs.com>
@francocipollone francocipollone added do-clang-test Runs clang and sanitizers builds do-static-analyzer-test Runs scan-build workflow and removed do-clang-test Runs clang and sanitizers builds do-static-analyzer-test Runs scan-build workflow labels Sep 26, 2023
@francocipollone
Include eol distros.
0b83878 
Signed-off-by: Franco Cipollone <franco.c@ekumenlabs.com>
@francocipollone francocipollone added do-clang-test Runs clang and sanitizers builds do-static-analyzer-test Runs scan-build workflow and removed do-clang-test Runs clang and sanitizers builds do-static-analyzer-test Runs scan-build workflow labels Sep 26, 2023
@francocipollone
Copy link
Collaborator Author

pybind/pybind11#1604

@francocipollone
Adds clang compiler flag.
0fee818 
Signed-off-by: Franco Cipollone <franco.c@ekumenlabs.com>
@francocipollone francocipollone added do-clang-test Runs clang and sanitizers builds do-static-analyzer-test Runs scan-build workflow and removed do-clang-test Runs clang and sanitizers builds do-static-analyzer-test Runs scan-build workflow labels Sep 28, 2023
@francocipollone
Removes scan build sup as it isn't necessary.
fcbcc60 
Signed-off-by: Franco Cipollone <franco.c@ekumenlabs.com>
@francocipollone francocipollone removed do-clang-test Runs clang and sanitizers builds do-static-analyzer-test Runs scan-build workflow labels Sep 28, 2023
@francocipollone francocipollone added do-clang-test Runs clang and sanitizers builds do-static-analyzer-test Runs scan-build workflow labels Sep 28, 2023
@francocipollone francocipollone changed the title Fixes scan build CI. Fixes clang build Sep 28, 2023
@francocipollone
Copy link
Collaborator Author

Going in and retriggering CI in maliput infra.

@francocipollone francocipollone merged commit 455083b into main Sep 28, 2023
11 checks passed
@francocipollone francocipollone deleted the francocipollone/fix_scan_build branch September 28, 2023 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agalbachicar agalbachicar Awaiting requested review from agalbachicar

Assignees
No one assigned
Labels
do-clang-test Runs clang and sanitizers builds do-static-analyzer-test Runs scan-build workflow
Projects
Maliput - Core development
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@francocipollone