[#6] Improve create action readability

malparty · Jun 17, 2021 · 4788a17 · 4788a17
1 parent 6112c9a
commit 4788a17
Showing 1 changed file with 8 additions and 5 deletions.
diff --git a/app/controllers/keywords_controller.rb b/app/controllers/keywords_controller.rb
@@ -7,11 +7,14 @@ def create
     keyword = params['keyword']
     raw_response = GoogleService::ClientService.new(keyword).query_result
 
-    return redirect_to keywords_path, alert: I18n.t('keywords.could_not_query') unless raw_response
+    if raw_response
+      render :create, locals: {
+        keyword: keyword,
+        raw_response: raw_response
+      }
+      return
+    end
 
-    render :create, locals: {
-      keyword: keyword,
-      raw_response: raw_response
-    }
+    redirect_to keywords_path, alert: I18n.t('keywords.could_not_query')
   end
 end