Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation fixes for Portuguese #2

Merged
merged 2 commits into from
May 25, 2018
Merged

Conversation

ciceromsjr
Copy link
Contributor

I applied the recommendations gave by the owner of this project.

@ciceromsjr
Copy link
Contributor Author

I don't know why but it has some conflicts (this is the first time I contribute to a project on Github).

I think you can just consider the final version of the xml-pt/icd_labels.xml file

@maltaisn maltaisn merged commit 83d486c into maltaisn:master May 25, 2018
@maltaisn
Copy link
Owner

Thanks, great job! I added it to v1.1.

I also added IconView with an attribute for setting the icon by ID in XML. I couldn't make it preview in the layout editor however, I think it's impossible due to how icon drawables use reflection to be created.

Deya360 added a commit to Deya360/icondialoglib that referenced this pull request Apr 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants