replacing use of deprecated ruamel.yaml.safe_load #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peci1
reviewed
Oct 28, 2023
boa/core/test.py
Outdated
| @@ -64,7 +64,8 @@ def get_metadata(yml, config, is_pyproject_recipe=False): | |||
|
|
|||
| d = toml.load(fi)["tool"]["boa"] | |||
| else: | |||
| d = ruamel.yaml.safe_load(fi) | |||
| loader = YAML(typ="safe") | |||
There was a problem hiding this comment.
tsibley
reviewed
Oct 30, 2023
There was a problem hiding this comment.
The dependency on ruamel.yaml
Line 17 in 6aa7b7c
should likely be updated to specify a minimum version to ensure the YAML(typ="safe") support is present, e.g.
ruamel.yaml >=0.15.0
if I'm reading the docs correctly about the first version to support it. (Changelog is unclear.)
boa/core/test.py
Outdated
| @@ -64,7 +64,8 @@ def get_metadata(yml, config, is_pyproject_recipe=False): | |||
|
|
|||
| d = toml.load(fi)["tool"]["boa"] | |||
| else: | |||
| d = ruamel.yaml.safe_load(fi) | |||
| loader = YAML(typ="safe") | |||
There was a problem hiding this comment.
The equivalent of safe_load(…) is documented to be YAML(typ="safe", pure=True).load(…). The pure=True argument is noted in the deprecation warning and should likely be used here.
|
How about just using |
|
Hello, any update on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the latest release of
ruamel.yamlversion0.18.2, nowsafe_loadis removed. In this PR updating a remaining usage of it.