Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add channel specific job with new str #2277

Merged
merged 3 commits into from
Feb 9, 2023
Merged

Conversation

AntoinePrv
Copy link
Member

Currently, using a spec like conda-forge::python will segfault in MSolver::all_problems_structured because channel specific jobs are added as a queue qith SOLVER_JOB_ONE_OF. In all_prblem_structured, the queue id is popping back as a dep but isn't.
There is not easy way to check for it explicitly, and no way to kepp track of the the fact that it was an explicit channel job.

The fix proposed here is rather to change the implementation of add_channel_specific_jobs to dynamically add a spec for the channel specific spec.

@AntoinePrv AntoinePrv requested a review from wolfv February 9, 2023 10:45
@AntoinePrv
Copy link
Member Author

@wolfv Regarding the conda-forge::python syntax, this is mamba specific?
I wonder if an python@conda-forge would be better to work with URL channels (a separate reflection)

@wolfv
Copy link
Member

wolfv commented Feb 9, 2023

No, it is not mamba specific. The channel:namespace:packagename syntax comes from conda https://github.com/conda/conda/blob/2e3f909cba109cdd7642387722223aa5cb79fd5c/conda/models/match_spec.py#L88-L92

@jonashaag
Copy link
Collaborator

fyi @ThomasBlauthQC

@wolfv wolfv merged commit 6487899 into mamba-org:main Feb 9, 2023
@AntoinePrv AntoinePrv deleted the channel-jobs branch February 27, 2023 14:39
@AntoinePrv AntoinePrv added type::bug Something isn't working where::libsolv labels Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type::bug Something isn't working where::libsolv
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants