Fix segfault in add_pin/all_problems_structured #2428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohanMabille
approved these changes
Mar 30, 2023
|
This assumes that a pin is installed though, right? |
|
If the pin is not installed, then it will get installed with this new version. Do we want to have pins that are not installed? Something like install |
Klaim
approved these changes
Mar 30, 2023
AntoinePrv
force-pushed
the
bug-solver
branch
2 times, most recently
from
75caca0
to
e8d6b3d
Compare
2 tasks
This was referenced Apr 15, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a segfault that appears in using a combinaison of
Msolver::add_pinandMSolver::all_problems_structured(called on solving error).The problem is similar than the one fixed in #2277.
The new implementation aliasesMSolver::add_job(see comment for explanation).