-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make GCS bucket location configurable #512
Conversation
Linting error will disappear after #513 is merged. |
I'm not entirely sure what to do about the failing unit tests:
But this seems to affect multiple PRs and is probably not related to my changes. Seems to be related to authlib: lepture/authlib#376 |
Also fixed in #513 |
Thanks, this looks good to me! |
I just rebased to see if tests are passing. |
Codecov Report
@@ Coverage Diff @@
## main #512 +/- ##
==========================================
- Coverage 83.21% 82.29% -0.92%
==========================================
Files 78 78
Lines 5891 5892 +1
==========================================
- Hits 4902 4849 -53
- Misses 989 1043 +54
Continue to review full report at Codecov.
|
Thanks for merging this so quickly, @wolfv! Would it be too much to ask for a new Quetz release, so we try out this feature? 👼 |
Closes #511