fix: mmap permission denied #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baszalmstra
force-pushed
the
fix/soft_link_error
branch
3 times, most recently
from
8c89533
to
204f3bb
Compare
baszalmstra
force-pushed
the
fix/soft_link_error
branch
from
204f3bb
to
33aafcd
Compare
|
Although this is not strictly required I think it cleans up the code, so Ill merge anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an attempt to fix the issue described in prefix-dev/pixi#234.
After some investigation, it appears that specifically on macOS it is not allowed to memory map a file that was mounted into an x86 based docker image. This PR adds more diagnostic errors and falls back to reading the entire file to memory if memory mapping fails. In the future it might be nice to stream the file in and do the replacement on the fly.