Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: download and cache repodata.json #55

Merged
merged 14 commits into from
Feb 20, 2023

Conversation

baszalmstra
Copy link
Collaborator

@baszalmstra baszalmstra commented Feb 16, 2023

This PR adds the ability to download and cache repodata similar to how Mamba and Conda work. This PR implements the proposal from conda/ceps#46, and adds support for zst and bz2 compressed files. Using file locks it also supports multiple processes to use the same on-disk cache. JLAP is not supported.

What I still want to do:

  • I need to add some spawn_blocking here and there.
  • Ability to track progress (for CLI usage).
  • Integrate this function into the already existing RequestRepoDataBuilder or just remove that.

Nonetheless, I could already use some feedback!

Also resolves #47

@baszalmstra baszalmstra changed the title Feat/repodata cache feat: download and cache repodata.json Feb 16, 2023
@baszalmstra baszalmstra mentioned this pull request Feb 20, 2023
Copy link
Contributor

@aochagavia aochagavia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

crates/rattler-bin/src/commands/create.rs Show resolved Hide resolved
@baszalmstra baszalmstra marked this pull request as ready for review February 20, 2023 14:14
@baszalmstra baszalmstra merged commit 22bbffa into mamba-org:main Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove dependency on extendhash
3 participants