fix: Address (#648) Missing FileMode causes an AttributeError in py-rattler and fix missing properties #651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI @baszalmstra |
|
The PR looks good to me but I am wondering if this is the right behavior. I believe that there is a default, probably binary, that should be the default value when the file type is unknown. Let me double check! |
|
OK, I double checked and now I do think that this is the correct behavior! Sorry for the noise. |
|
@wolfv no worries! Yeah, this |
…erties for paths_data entries in py-rattler run ruff run ruff
iamthebot
force-pushed
the
al--fix_no_filemode
branch
from
75568ce
to
13239ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contains a fix for #648 by defaulting
_innertoNonewhich prevents anAttributeErrorif trying to get whichFileModewe have in the case where theFileModeisn't defined. It further adds anunknownproperty to check for this case specifically in Python.I've also added a few property decorators that were missing in that file (eg; for
sha256).Note a few files were also slightly reformatted when running ruff so I've added those to spare folks the trouble later (unit tests/conftest).