Allow returning "unknown dependencies" in get_dependencies
#17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You are on 🔥! And yes to the question! Because that would be ideal to show in a unsat report |
aochagavia
force-pushed
the
tweak-dependency-provider
branch
from
b344fba
to
66fb74d
Compare
|
All right, just pushed the changes. And here's a diff showing how it looks like in rip. |
aochagavia
force-pushed
the
tweak-dependency-provider
branch
from
66fb74d
to
7ff5f2d
Compare
|
BTW, I am hoping to add a user customizable error string for unknown dependencies in pubgrub. So I think it is a good idea here too! |
|
Nice work @aochagavia! :) Let's get your PRs reviewed and merged tomorrow 🚀 |
This makes it possible for a DependencyProvider to signal that it failed to retrieve a solvable's depenencies (instead of crashing). The consequence is that the original solvable is marked as excluded.
aochagavia
force-pushed
the
tweak-dependency-provider
branch
from
7ff5f2d
to
c569a2a
Compare
baszalmstra
approved these changes
Jan 25, 2024
tdejager
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this assumes #15 and #16 are merged.
Question: should we make it possible for the provider to tell the reason why the dependencies are unknown? For instance, a string where we can put the contents of this panic
Closes #14