-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Revert "util/bitstream.cpp: Fixed cases where bits would be dropped w…
…hen reading and writing. (#12057)" This reverts commit 69c3cd7. This causes CHD SHA1 digests to change. Either it's buggy, or CHD SHA1 digests depend on the representation rather than the data itself.
- Loading branch information
Showing
1 changed file
with
13 additions
and
45 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
229d19d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After I was doing some more thorough checks I had noticed the SHA1 value was different when I extracted and recreated CHDs so I requested a revert just to be sure due to the release deadline, but after more checks I don't think this PR had anything to do with it.
I was able to track down a change to an older PR of mine (#10231) that fixed an actual bug which resulted in data being changed, but even older than that (I checked up to 0.228 but it's even older) there was another change that changed the PGSUB metadata field's value that seems to be causing the overall SHA1 to change.
More recently created CHDs seem to be recreateable with the same SHA1s.
Example of old (2013) CHD (
PGSUB:RW
):Recreated (
PGSUB:NONE
):