Skip to content

Commit

Permalink
namcos23: remove obsolete comment
Browse files Browse the repository at this point in the history
  • Loading branch information
happppp committed Sep 19, 2023
1 parent 17a84d1 commit 9de7dda
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 8 deletions.
6 changes: 3 additions & 3 deletions src/mame/hegenerglaser/roma2.cpp
Expand Up @@ -178,14 +178,14 @@ void roma2_state::roma2(machine_config &config)
M68000(config, m_maincpu, 9.8304_MHz_XTAL);
m_maincpu->set_addrmap(AS_PROGRAM, &roma2_state::main_map);

const attotime irq_period = attotime::from_hz(9.8304_MHz_XTAL / 0x14000); // 120Hz
m_maincpu->set_periodic_int(FUNC(roma2_state::irq5_line_hold), irq_period);

HC259(config, m_outlatch);
// Q0-Q3: input mux; Q4: strobe; Q6-Q7: DAC
m_outlatch->q_out_cb<4>().set(m_display, FUNC(mephisto_display1_device::strobe_w));
m_outlatch->parallel_out_cb().set(m_dac, FUNC(dac_byte_interface::write)).rshift(6).mask(3);

const attotime irq_period = attotime::from_hz(9.8304_MHz_XTAL / 0x14000); // 120Hz
m_maincpu->set_periodic_int(FUNC(roma2_state::irq5_line_hold), irq_period);

MEPHISTO_SENSORS_BOARD(config, m_board);
m_board->set_delay(attotime::from_msec(200));

Expand Down
9 changes: 4 additions & 5 deletions src/mame/namco/namcos23.cpp
Expand Up @@ -120,7 +120,7 @@
motoxgo(all) Inputs don't respond at all. Hardlocks shortly in atract mode.
downhill Freeze with black screen after POST.
downhillu Heavy gfx glitches. Missing rotary inputs. Random freezes.
timecrs2(all) Playable with some gfx glitches up until stage 1-2 (see sub_comm_r).
timecrs2(all) Playable with some gfx glitches
panicprk,j,j2 Freezes during 'SUB-READY WAIT' after POST (see sub_comm_r).
gunwars,a Hardlocks after POST (gmen related?).
raceon Hardlocks after POST (gmen related?).
Expand Down Expand Up @@ -3073,7 +3073,7 @@ void namcos23_state::mcuen_w(offs_t offset, uint16_t data, uint16_t mem_mask)
default:
// For some reason, the main program write the high 16bits of the
// 32 bits words of itself there...
// logerror("mcuen_w: mask %04x, data %04x @ %x\n", mem_mask, data, offset);
//logerror("mcuen_w: mask %04x, data %04x @ %x\n", mem_mask, data, offset);
break;
}
}
Expand All @@ -3082,7 +3082,6 @@ void namcos23_state::mcuen_w(offs_t offset, uint16_t data, uint16_t mem_mask)
// C?? (unknown comms)

// while getting the subcpu to be ready, panicprk sits in a tight loop waiting for this AND 0002 to be non-zero (at PC=BFC02F00)
// timecrs2 locks up in a similar way as panicprk, at the beginning of the 2nd level, by reading/writing to this register a couple of times
uint16_t namcos23_state::sub_comm_r(offs_t offset)
{
// status register
Expand Down Expand Up @@ -3314,7 +3313,7 @@ void namcos23_state::s23h8rwmap(address_map &map)
map(0x300000, 0x300003).noprw(); // seems to be more inputs, maybe false leftover code from System 12?
map(0x300010, 0x300011).noprw();
map(0x300020, 0x300021).w(FUNC(namcos23_state::sub_interrupt_main_w));
map(0x300030, 0x300031).nopw(); // timecrs2 writes this when writing to the sync shared ram location, motoxgo doesn't
map(0x300030, 0x300031).nopw(); // timecrs2 writes this when writing to the sync shared ram location, motoxgo doesn't
}


Expand Down Expand Up @@ -3547,7 +3546,7 @@ static INPUT_PORTS_START( finfurl )
PORT_BIT( 0x2000, IP_ACTIVE_LOW, IPT_JOYSTICK_RIGHT ) PORT_NAME("Whip Button R")

PORT_MODIFY("ADC0")
PORT_BIT( 0x3ff, 0x0200, IPT_AD_STICK_Y ) PORT_SENSITIVITY(100) PORT_KEYDELTA(10) PORT_NAME("Swing")
PORT_BIT( 0x3ff, 0x0200, IPT_AD_STICK_Y ) PORT_SENSITIVITY(100) PORT_KEYDELTA(10) PORT_NAME("Swing")

PORT_MODIFY("ADC1")
PORT_BIT( 0x3ff, 0x0200, IPT_AD_STICK_X ) PORT_SENSITIVITY(100) PORT_KEYDELTA(10) PORT_NAME("Handle") PORT_REVERSE
Expand Down

0 comments on commit 9de7dda

Please sign in to comment.