Clean genie scripts from missing/duplicate files #7770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix was needed because genie generated cmake files will complain about files that does not exist. Digging enough into genie scripts showed that building scripts also lacked some files or had duplicate ones.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix was needed because genie generated cmake files will complain about files that does not exist. Digging into genie scripts showed that building scripts also lacked some files, had duplicate ones or wrong named ones. All happened on header files, probably that's the reason why the problem didn't show up.
On some files also the scripts ended with having only cpp sources (ie. m5), having read their includes I realized that they may not need it, but I ask for a complete review of this even if I compiled mame successfully and started those systems.