Eliminate ARRAY_LENGTH template in favor of C++17's std::size #7787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* osdcomm.h: Move definition of EQUIVALENT_ARRAY to coretmpl.h * sharc.cpp, gt64xxx.cpp, ym2413.cpp, gb_lcd.cpp, snes_ppu.cpp: Use STRUCT_MEMBER for save state registration * gio/newport.cpp, megadrive/svp.cpp, nes_ctrl/bcbattle.cpp, arm7.cpp, tms9995.cpp, pckeybrd.cpp, sa1110.cpp, sa1111.cpp, jangou_blitter.cpp, vic4567.cpp: Use std::fill(_n) instead of memset * emucore.h: Remove obsolete typedef
cuavas
reviewed
Feb 15, 2021
| @@ -283,8 +280,7 @@ void snes_ppu_device::device_start() | |||
| save_item(STRUCT_MEMBER(m_layer, mosaic_counter)); | |||
| save_item(STRUCT_MEMBER(m_layer, mosaic_offset)); | |||
|
|
|||
| for (int i = 0; i < ARRAY_LENGTH(m_clipmasks); i++) | |||
| save_item(NAME(m_clipmasks[i]), i); | |||
| save_item(NAME(m_clipmasks)); | |||
There was a problem hiding this comment.
I intentionally had these as separate items because there’s a relatively small number of them (only 6) and it’s easier to find where one ends and the next starts in the debugger if they’re separate sources.
Comment on lines
+254
to
+259
| save_item(STRUCT_MEMBER(m_scanlines, enable)); | ||
| save_item(STRUCT_MEMBER(m_scanlines, clip)); | ||
| save_item(STRUCT_MEMBER(m_scanlines, buffer)); | ||
| save_item(STRUCT_MEMBER(m_scanlines, priority)); | ||
| save_item(STRUCT_MEMBER(m_scanlines, layer)); | ||
| save_item(STRUCT_MEMBER(m_scanlines, blend_exception)); |
There was a problem hiding this comment.
Likewise, I didn’t use STRUCT_MEMBER for these because there are only two, and it’s easier to find the start/end of each if they’re separate sources.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
osdcomm.h: Move definition of EQUIVALENT_ARRAY to coretmpl.h
sharc.cpp, gt64xxx.cpp, ym2413.cpp, gb_lcd.cpp, snes_ppu.cpp: Use STRUCT_MEMBER for save state registration
gio/newport.cpp, megadrive/svp.cpp, nes_ctrl/bcbattle.cpp, arm7.cpp, tms9995.cpp, pckeybrd.cpp, sa1110.cpp, sa1111.cpp, jangou_blitter.cpp, vic4567.cpp: Use std::fill(_n) instead of memset
emucore.h: Remove obsolete typedef
Note: I'm opening this pull request to see how the CI builds deal with the changes, which affect OSD stuff which has caused some unpleasant surprises with past refactorings. I don't have total confidence that all compilers support the standard equally well.