Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

genie: Explicitly set LinkSupportCircularDependencies for NetBSD #10020

Merged
merged 1 commit into from
Jul 3, 2022

Conversation

0-wiz-0
Copy link
Contributor

@0-wiz-0 0-wiz-0 commented Jul 1, 2022

Fixes #10011 following a suggestion by @cuavas.

@cuavas
Copy link
Member

cuavas commented Jul 1, 2022

Will this affect other BSDs as well?

@0-wiz-0
Copy link
Contributor Author

0-wiz-0 commented Jul 1, 2022

I'm pretty sure this should be extended to OpenBSD and FreeBSD as well, but I can't test, so I didn't. Let me know if I should add them anyway.

@cuavas
Copy link
Member

cuavas commented Jul 1, 2022

Why not use configuration { "*bsd" } if you want it to affect the other BSD targets as well?

@0-wiz-0
Copy link
Contributor Author

0-wiz-0 commented Jul 1, 2022

I cannot test on FreeBSD and OpenBSD, that's why I limited the change to NetBSD by purpose.
Summoning @evadot: I think you maintain the FreeBSD package for mame
Summoning @fcambus: I think you maintain the OpenBSD package for mame

@fcambus
Copy link
Contributor

fcambus commented Jul 2, 2022

I successfully built mame 0.245 on OpenBSD without needing this modification, so it's apparently not required for us.

@0-wiz-0
Copy link
Contributor Author

0-wiz-0 commented Jul 2, 2022

@fcambus thanks for testing. If I understand correctly, OpenBSD nowadays uses lld, so that's probably the reason it works.

@fcambus
Copy link
Contributor

fcambus commented Jul 3, 2022

@0-wiz-0 Indeed, LLD is the default linker on most architectures, including the ones on which we build MAME (amd64 and i386).

@cuavas
Copy link
Member

cuavas commented Jul 3, 2022

I’ll merge this for now to keep things moving.

@cuavas cuavas merged commit 174e6bd into mamedev:master Jul 3, 2022
@0-wiz-0
Copy link
Contributor Author

0-wiz-0 commented Jul 3, 2022

Thanks, @cuavas!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

emulator_info symbols missing
3 participants