Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

konamim2.cpp: Redumped CD for 'heatof11' [Victor Fernandez (City Game), Arcade Planet] #10139

Merged
merged 5 commits into from
Apr 4, 2024
Merged

konamim2.cpp: Redumped CD for 'heatof11' [Victor Fernandez (City Game), Arcade Planet] #10139

merged 5 commits into from
Apr 4, 2024

Conversation

clawgrip
Copy link
Contributor

Dumped the CD with DIC and a Plextor, without errors.
Also reformatted comments and fix spacing.

@clawgrip
konamim2.cpp: Redumped CD for 'heatof11' [Victor Fernandez (City Game)]
c1bbeae 
Dumped the CD with DIC and a Plextor, without errors.
Also reformatted comments and fix spacing.
@clawgrip clawgrip changed the title konamim2.cpp: Redumped CD for 'heatof11' [Victor Fernandez (City Game)] konamim2.cpp: Redumped CD for 'heatof11' [Victor Fernandez (City Game), Arcade Planet] Jul 27, 2022
@clawgrip
Copy link
Contributor Author

Please, use the credits from the PR description, not from its inner commit

@clawgrip clawgrip marked this pull request as draft July 27, 2022 20:52
@clawgrip clawgrip marked this pull request as ready for review July 28, 2022 09:53
@clawgrip
Copy link
Contributor Author

The CHD does not include the subtrack info extracted with DIC.
If anyone knows how to convert a CCD image (with subs info) into a CHD (inclusing that subtrack info), please tell me how. I've tried to generate a cdrdao image with raw subtrack info, but chdman cannot deal with cdrdao images...

@rb6502
Copy link
Contributor

rb6502 commented Jul 28, 2022

CHDMAN originally only dealt with cdrdao bin/toc images, including the subcode data. What's going wrong?

@clawgrip clawgrip marked this pull request as draft July 28, 2022 12:23
@clawgrip
Copy link
Contributor Author

My bad. Don't know what I was doing, but it converts fine.
I'll update the PR with the new hash, for the last CHD including subs info

Thanks a lot!!!!!

@clawgrip clawgrip marked this pull request as ready for review July 28, 2022 12:55
cuavas
cuavas requested changes Jul 28, 2022
View reviewed changes
src/mame/konami/konamim2.cpp Outdated
Comment on lines 1298 to 1297
#if 0
/*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don’t do this. Disabled code will still be pre-processed, and comments are reformatted by srcclean to not use tabs beyond the indent level of the opening delimiter.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, thanks! Just to learn... Why would we need a commented-out ROM definition to be preprocessed?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because if it’s at least preprocessed, it at least has to contain valid C++ tokens, so it catches certain kinds of code rot earlier. Also editors and tools like MAME’s srcclean treat disabled code differently to comments.

src/mame/konami/konamim2.cpp Outdated
Comment on lines 1386 to 1390
#if 0
/*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don’t do this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

src/mame/konami/konamim2.cpp Outdated
Comment on lines 1433 to 1438
#if 0 // FIXME
/*
// FIXME
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once again, please don’t mess with stuff like this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, thx!

cuavas
cuavas approved these changes Sep 13, 2022
View reviewed changes
Copy link
Member

@cuavas cuavas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks OK as far as a checklist review goes. Does this new CHD meet the approval of the CD image aficionados and Konami experts?

@clawgrip
Copy link
Contributor Author

clawgrip commented Sep 13, 2022 •
edited
Loading

I followed the instructions from the people at redump.org (specifically for adding the subtrack info). I sent them a copy for verification too.

@clawgrip
Copy link
Contributor Author

@cuavas Any change request about this PR? Can it be committed?

Thanks

@cuavas
Copy link
Member

cuavas commented Nov 24, 2022

@cuavas Any change request about this PR? Can it be committed?

Well, I’m not the foremost expert on CD-ROM or the Konami M2 stuff. I was hoping other developers who are more into that kind of thing would obtain the CHD and do quality checks on it.

@angelosa
Copy link
Member

This needs conflicts resolved, I'll apply this once done.

@clawgrip
Copy link
Contributor Author

This needs conflicts resolved, I'll apply this once done.

Done, thanks a lot!!!!

@angelosa angelosa merged commit 141b195 into mamedev:master Apr 4, 2024
5 checks passed
@clawgrip clawgrip deleted the patch-9 branch April 4, 2024 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cuavas cuavas cuavas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@clawgrip @rb6502 @cuavas @angelosa