Apple II: fix Video-7 RGB card double hi-res modes #10797
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix an off-by-1 error in the 160-column mode that caused the rightmost 2 pixels to be omitted. In 140-column color and mixed modes, use custom logic to make 140 wide pixels instead of simulating blurry artifact color. In mixed mode, each high bit controls 7 narrow pixels according to the manual. With these changes, the card seems to pass all of the tests on the official demo disk, except that foreground-background hires remains unimplemented, "Color Mouse Draw" seems to hang/crash, and some demos sometimes set the wrong mode when run after other demos (including themselves). The last could be a bug in the demos.
rb6502
reviewed
Jan 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix an off-by-1 error in the 160-column mode that caused the rightmost 2 pixels to be omitted. In 140-column color and mixed modes, use custom logic to make 140 wide pixels instead of simulating blurry artifact color. In mixed mode, each high bit controls 7 narrow pixels according to the manual.
With these changes, the card seems to pass all of the tests on the official demo disk, except that foreground-background hires remains unimplemented, "Color Mouse Draw" seems to hang/crash, and some demos sometimes set the wrong mode when run after other demos (including themselves). The last could be a bug in the demos.