hng64.cpp: Hyper NeoGeo 64 video updates #10891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
commented
Feb 11, 2023
•
ghost
commented
- filter out most (but not all) the bad polygons in roadedge / xrally by handling display list more correctly
- fixed 4bpp texture handling (they were being treated as 'low resolution' textures, throwing away 3/4 of the data) (used extensively for background details on sams64/sams64_2)
- added 4bpp texture decode for easy viewing of the 4bpp texture pages, handy for debugging
- fixed some texture palette issues connected to the 4bpp textures and incorrect enable bits being used (wheels+windscreen palette in racing games for example)
- found a flag which seems to enable/disable the backface culling, improves bbust2 school bus without breaking roadedge
- a few small tidyups / cleanups (disabled some printf/logerrors that would be heavily spammed at times)
- add ADK as the developer of bbust2 (SNK/ADK is credited in the ending, even if not on the title screen)
added 10 commits
February 11, 2023 19:53
…ng can probably be improved too)
… way in the viewer
…bbust2 school bus to appear properly without breaking course graphics in roadege/xrally
ghost
changed the title
ghost
marked this pull request as ready for review
happppp
reviewed
Feb 13, 2023
happppp
reviewed
Feb 13, 2023
cuavas
reviewed
Feb 14, 2023
Comment on lines
1722
to
+1734
| static const uint32_t texlayout_xoffset[1024] = { STEP1024(0,8) }; | ||
| static const uint32_t texlayout_yoffset[512] = { STEP512(0,8192) }; | ||
| static const gfx_layout hng64_texlayout = | ||
| static const uint32_t texlayout_yoffset[1024] = { STEP1024(0,8192) }; | ||
|
|
||
| static uint32_t texlayout_xoffset_4[1024]; | ||
| static const uint32_t texlayout_yoffset_4[1024] = { STEP1024(0,4096) }; | ||
|
|
||
| void hng64_state::texlayout_xoffset_4_create() | ||
| { | ||
| for (int i = 0; i < 1024; i++) | ||
| { | ||
| texlayout_xoffset_4[i] = (i * 4) ^ 4; | ||
| } | ||
| } |
There was a problem hiding this comment.
It’s actually possible to generate this at compile time. I’ll patch it up after merging I guess.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.