Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New driver for Brother wordprocessor/typewriter LW-840ic #10997

Merged
merged 5 commits into from Mar 19, 2023
Merged

New driver for Brother wordprocessor/typewriter LW-840ic #10997

merged 5 commits into from Mar 19, 2023

Conversation

BartmanAbyss
Copy link
Contributor

split off of PR#8202

cuavas
cuavas requested changes Mar 16, 2023
View reviewed changes
src/mame/brother/lw840.cpp Outdated Show resolved Hide resolved
src/mame/brother/lw840.cpp Outdated Show resolved Hide resolved
src/mame/brother/lw840.cpp Outdated Show resolved Hide resolved
src/mame/brother/lw840.cpp Outdated Show resolved Hide resolved
src/mame/brother/lw840.cpp Outdated Show resolved Hide resolved
src/mame/brother/lw840.cpp Outdated Show resolved Hide resolved
src/mame/brother/lw840.cpp Outdated Show resolved Hide resolved
cuavas
cuavas reviewed Mar 19, 2023
View reviewed changes
Copy link
Member

@cuavas cuavas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There’s the question of whether the GM82C765B should go in src/devices/machine/upd765.cpp so other things can potentially use it, too.

src/mame/brother/lw840.cpp Outdated Show resolved Hide resolved
src/mame/brother/lw840.cpp Outdated Show resolved Hide resolved
@cuavas cuavas merged commit 1fa76ca into mamedev:master Mar 19, 2023
0 of 5 checks passed
@BartmanAbyss
Copy link
Contributor Author

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cuavas cuavas cuavas requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@BartmanAbyss @cuavas