BGFX and D3D9 renderer fixes for issues #11104, #11106, and #11107 #11249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 19, 2023 13:43
…led. (mamedev#11104) [Ryan Holtz]
|
Thanks RB - be sure to close out the associated issues citing this PR. :) |
pauldevine
pushed a commit
to pauldevine/mame
that referenced
this pull request
Jun 21, 2023
… and mamedev#11107 (mamedev#11249) * -hlsl.json: Removed duplicate scanline_variation setting. (mamedev#11107) [Ryan Holtz] * -d3dhlsl.cpp: Fixed lack of post-pass application when bloom is disabled. (mamedev#11104) [Ryan Holtz] * -drawd3d.cpp: Always set a default texture at scene start. (mamedev#11106) [Ryan Holtz]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #11107: Simply removed the erroneously copy/pasted line.
Fix for #11106: Avoiding redundant state-set calls was going awry. We now ensure that the first
set_texturecall of a scene always succeeds by clearing the cached texture pointer at frame start.Fix for #11104: Calling
post_passanddownsample_passto generate bloom targets when bloom is disabled was causing issues when applying the post/shadowmask pass. Avoid calling them entirely if bloom is disabled, since the downsampled targets are not used anyway.