machine/wd_fdc.cpp: Simplify/optimize how bus inverting is handled #11375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgarlanger
commented
Jun 25, 2023
| @@ -99,7 +99,7 @@ class wd_fdc_device_base : public device_t { | |||
| bool disable_mfm; | |||
| bool enmf; | |||
| bool has_enmf; | |||
| bool inverted_bus; | |||
| uint8_t bus_invert_value; | |||
There was a problem hiding this comment.
I wasn't really happy with the name of the variable, if someone has a better idea, let me know.
cuavas
changed the title
cuavas
changed the title
|
@galibert do you have an opinion on this? It looks correct, and it’s a net reduction in source code lines. I wouldn’t count on it improving performance – a test/conditional move is likely just as fast as loading the value from a data member. |
|
Yeah, I don't see that as having any performance impact, whatever :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplifies how bus inverting is handled, no longer has an if check, but always perform an xor with the value defined in the class. For chips that do inverting, the value will be set to 0xff. For chips without inverting, it is set to 0x00.