removes SDL_WINDOW_BORDERLESS flag #11546
Conversation
Meant to address the issue reported here: mamedev#7532 (comment) And possibly here: mamedev#7922 (comment)
|
Does this have a detrimental effect on any platforms? What happens on Windows and macOS when this flag is not specified? |
|
I honestly don't know. To be completely honest, I don't fully understand what a borderless window is. All that said, these days I see borderless as optional in probably most games nowadays. Currently MAME seems to force it's fullscreen window to always be of the borderless variety at least when SDL is being used. |
|
I tested this on Windows with two displays, and it seemed to work. I think you’re supposed to either specify full screen, or the combination of borderless and maximised, but not a combination. A borderless window won’t have “decorations” like a title bar, window frame, shadow, etc. Depending on the OS and window manager, there may be a distinction between a borderless window that covers an entire display, and an application taking exclusive control of a display. |
|
Oh ok cool. :) |
|
FWIW, non-borderless full screen is deprecated by both Microsoft and Apple and we no longer use it at work. I think this is probably an SDL bug and I greatly oppose this change. |
You're missing the point - SDL always creates a borderless window when you specify fullscreen if it isn't using exclusive mode. If you want it to always use borderless fullscreen (never use exclusive mode, never change resolution), you need to specify borderless and maximised. Specifying a combination of fullscreen and borderless confuses it. |
Meant to address the issue reported here:
#7532 (comment) And possibly here:
#7922 (comment)