nltool: report line number when an exception occurs #11564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cuavas
reviewed
Oct 25, 2023
Comment on lines
+343
to
+347
| catch (plib::pexception &e) | ||
| { | ||
| fprintf(stderr, "Error on line: <%d>\n", linenumber); | ||
| throw(e); | ||
| } |
There was a problem hiding this comment.
There are three issues here:
- You should catch by
constreference unless there’s a very good reason not to. throwis not a function and shouldn’t be formatted like one – it’s a flow control construct likereturn.- You should use
throw;on its own to re-throw a caught exception.
|
@rb6502 can you please fix this up? It fails on basic C++. |
|
I could fix those up when I'm back from my vacation in a week unless someone else wants to beat me to it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to convert a KiCad netlist and when a component value was missing or not a number nltool would only report
Exception caught: Error converting string to number:but not what component or line was meant.This PR counts the lines, prints the line number to stderr and passes on the exception.