apple/apple2video.cpp: Fix Apple II DHGR rendering in Color/Composite mode #11595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix DHGR rendering when in Color/Composite mode (rgbmode == -1), so it doesn't fall through to the Video-7 RBG rendering, where only rgbmode == 1 or rgbmode == 3 is expected. DHGR graphics look much better when the color artifact emulation is applied, which the Video-7 rendering does not do.
cuavas
changed the title
Luigi30
pushed a commit
to Luigi30/mame
that referenced
this pull request
Oct 5, 2023
…te mode. (mamedev#11595) Fixes regression causing Video-7 RGB rendering to be used when (rgbmode == -1).
Luigi30
pushed a commit
to Luigi30/mame
that referenced
this pull request
Oct 5, 2023
…te mode. (mamedev#11595) Fixes regression causing Video-7 RGB rendering to be used when (rgbmode == -1).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix DHGR rendering when in Color/Composite mode (rgbmode == -1, in this function), so it doesn't fall through to the Video-7 RBG rendering, where only rgbmode == 1 or rgbmode == 3 is expected. DHGR graphics look much better when the color artifact emulation is applied, which the Video-7 rendering does not do.
This returns the rendering back to what it was like in the MAME 252. The bIsRGBMonitor was removed, as it seems to just be a patch to try and fix the issue introduced in 253, where the monochrome flag was added. The addition of bIsRGBMonitor just made it so that when rgbmode was -1 in the function, it acted like rgbmode == 3, but that is not ideal.
This was tested using a Total Replay image, and playing DHGR games, such as Airheart and Heavy Barrel.