xavix.cpp - treat taikodp drum input as digital to avoid issue with multiple hits (same workaround as namcos10 taiko games) #11620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ultiple hits (same workaround as namcos10 taiko games)
| @@ -590,10 +590,20 @@ static INPUT_PORTS_START( taikodp ) | |||
| PORT_INCLUDE(xavix_an) | |||
|
|
|||
| PORT_MODIFY("AN0") // 00 (read by one type of function, handled in timer interrupt at 0x1d92 in RAM) | |||
| #if 0 // should be more correct, but causes multiple hits to register | |||
There was a problem hiding this comment.
Haven't looked at xavix before but based on my experience with the Namco System 10 Taiko games, most likely the reason it's causing multiple hits is because the pedal input will automatically autocenter on release, and each new value is being recognized as a new hit. Ideally drum inputs should be an analog value (to get the registered hit velocity) but should otherwise act more similar to a digital input (once released it immediately goes back to 0, no auto centering or anything like that).
Taiko itself doesn't seem to actually make use of the velocity values in gameplay besides just checking if the drum was hit or not. And the home controllers for Taiko are actually digital inputs fwiw.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.