Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

megasys1.cpp - various cleanups based on new information etc. #11650

Merged
merged 25 commits into from Oct 26, 2023

Conversation

mamehaze
Copy link
Contributor

No description provided.

src/mame/jaleco/megasys1.cpp Outdated Show resolved Hide resolved
src/mame/jaleco/megasys1.cpp Outdated Show resolved Hide resolved
src/mame/jaleco/megasys1.cpp Outdated Show resolved Hide resolved
src/mame/jaleco/megasys1.h Outdated Show resolved Hide resolved
src/mame/jaleco/megasys1.h Outdated Show resolved Hide resolved
@mamehaze
Copy link
Contributor Author

mamehaze commented Oct 22, 2023

fwiw this also fixes the random crash with tshingen https://mametesters.org/view.php?id=8541
rather than doing it on startup, they do it when certain conditions are met.

tshingena has the same code but I'm not sure it's called

even plusalph has the checks in, those are called at the bonus round, so delayed protection not even unexpected

src/mame/jaleco/megasys1.h Outdated Show resolved Hide resolved
src/mame/jaleco/ms1_gatearray.cpp Outdated Show resolved Hide resolved
src/mame/jaleco/ms1_gatearray.cpp Outdated Show resolved Hide resolved
src/mame/jaleco/ms1_gatearray.cpp Outdated Show resolved Hide resolved
src/mame/jaleco/ms1_gatearray.cpp Outdated Show resolved Hide resolved
src/mame/jaleco/ms1_gatearray.h Outdated Show resolved Hide resolved
@mamehaze
Copy link
Contributor Author

feedback has been addressed, even if most of it wasn't even code I'd modified in the first place.

@cuavas cuavas merged commit 5217259 into mamedev:master Oct 26, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants