Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

universal/cosmic.cpp: Dumped and added a new Space Panic set #11689

Merged
merged 2 commits into from Nov 2, 2023

Conversation

clawgrip
Copy link
Contributor

New WORKING clone

Space Panic (set 4) [David Bosque, ClawGrip]

Also reformatted single line comments.

-----------------------------------------
Space Panic (set 4) [David Bosque, ClawGrip]
@cuavas
Copy link
Member

cuavas commented Nov 1, 2023

Have you examined the differences between this and the other sets at all? It looks like all the ROMs are different. Are the changes in code or data?

@clawgrip
Copy link
Contributor Author

clawgrip commented Nov 1, 2023

Have you examined the differences between this and the other sets at all? It looks like all the ROMs are different. Are the changes in code or data?

Six new ROMs, all in maincpu region, with small changes, from 1% to 2.5%. I've been playing for a while and it seems to work fine. The PCB is Universal original, the ROMs are on good shape and I got stable reads, reading each ROM five times, ensuring all pin contacts were fine (as I always do).

It's far from my skills telling what the differences are, sorry.

imagen

@cuavas
Copy link
Member

cuavas commented Nov 2, 2023

I’m just a bit concerned that it’s bit rot with some of these – the existing sets all share the same ROM at position 6, so it’s a surprise to find one that has all unique ROMs. They’re over forty years old now, so the EPROMs could be losing data even if they’ve been stored properly. With small changes like that, it could be a minor code update, but it could also be the beginning of bit rot.

I know disassembling the ROMs is a pile of work, but hopefully someone gives it the TCRF treatment at some point.

@cuavas cuavas merged commit 59d3924 into mamedev:master Nov 2, 2023
5 checks passed
@clawgrip clawgrip deleted the patch-8 branch November 2, 2023 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants