nec/pce*.cpp: Move super system card and arcade card emulation into its own files #11726
Conversation
…us/pce/pce_rom.cpp pce_cd.cpp: Use devcb for interrupt callback
…files, Add primary Arcade Card Duo support
cam900
changed the title
hash/pce.xml
Outdated
| <software name="acardduo" supported="no"> | ||
| <description>Arcade Card Duo</description> | ||
| <year>1994</year> | ||
| <publisher>NEC</publisher> | ||
| <part name="cart" interface="pce_cart"> | ||
| <feature name="slot" value="acard_duo" /> | ||
| <dataarea name="rom" size="262144"> | ||
| <!-- bios not included --> | ||
| </dataarea> | ||
| </part> | ||
| </software> |
There was a problem hiding this comment.
Lacking a BIOS means this option cannot be emulated. You shouldn't guess, given your past history makes me wonder if you even tested all this stuff.
There was a problem hiding this comment.
The Arcade Card Duo only contains the RAM needed for the Arcade titles as the Duo/Super CD System² came with the System Card 3.0 inbuilt.
Probably means the rom dataarea shouldn't be part of the entry
There was a problem hiding this comment.
That again implies the Arcade Card Duo is an option slot for a base system there's no real handling for.
I also have my doubts wrt this kind of fake entry in the SW list, looks an unnecessary bridge for something doable with -listslots alone.
There was a problem hiding this comment.
I see no reason why not to have it, as it'd take up the cart slot on the console much like RAM carts for like the Saturn
There was a problem hiding this comment.
Well it doesn't do anything to begin with, it needs a base machine for the Duo that internalizes the CD System Card and make sure it overrides the mapping if a card is present, or overlays in the case you want Arcade stuff.
https://nicole.express/2020/why-do-you-need-an-arcade-card.html
ETA: it also fails mame -validate anyway.
There was a problem hiding this comment.
The software item can be marginally if there are multiple ROM versions for the card as it avoids needing to use the kind of ugly slot card BIOS syntax. I wouldn’t have a problem if it became a slot option only, though.
I don’t have a problem with letting people plug an Arcade Card Duo into a system where it’s useless. You can do it in real life, it just won’t boot anything. Let it do the same in MAME.
…ion, Add notes Convert DRAM address register into struct, Add device_reset
There was a problem hiding this comment.
This looks mostly OK now. Getting this stuff into slot devices rather than machine configuration switches is a step forward.
@cam900 how many of the games that depend on the Arcade Cards have you tested? How extensively have you tested them?
@angelosa did you have any other issues with this? I think at this point it’s an improvement over what we’ve already got, and makes the Arcade Cards more self-contained so it’s easier to work on them in the future.
|
@cuavas it's implements bit rotate register in Arcade Card, but only sapphire is tested and confirmed works fine. |
This still happens btw, I'm not even gonna bother with a full regtest until it's fixed. |
|
There are some titles that can run with the Super CD system card, but will take advantage of the Arcade Card if it is available for enhancements. With the current state of this pull request, these games use the Super CD system card by default. @cam900 can you please try to identify the software items that can take advantage of an Arcade Card and update them to use an arcade card by default? This will give a better experience. |
|
Let’s YOLO this in and hope it makes the release. If there are CD titles that need their default system card changed, that’s easy to get in before the release goes out. If someone finds something horribly broken that we overlooked, we can fix it or back it out temporarily. |
mamedev#11726) * Moved expansion card emulation out of the system into card devices. * Removed machine configuration settings for expansion settings. * Started to modernise the HuCard slot interface. New working software list items (pce.xml) ------------------------ Arcade Card Pro
Use address_space instead read/write handler, Add primary Arcade Card Duo support
pce_cd.cpp: Use devcb for interrupt callback