megaplay.cpp - correctly set to 'export' region, as these aren't Japanese games, and shouldn't be running in Japanese. #11748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ames, and shouldn't be running in Japanese.
angelosa
reviewed
Nov 16, 2023
| @@ -969,7 +969,8 @@ void mplay_state::init_megaplay() | |||
| m_ic36_ram = std::make_unique<uint16_t[]>(0x10000 / 2); | |||
| m_ic37_ram = std::make_unique<uint8_t[]>(0x10000); | |||
|
|
|||
| init_megadrij(); | |||
| // use Export NTSC init, as MegaPlay was apparently only intended for export markets. | |||
| init_megadriv(); | |||
There was a problem hiding this comment.
The init method name is confusing, it makes me think of PAL MD but under the hood it really initializes to NTSC -> init_genesis?
There was a problem hiding this comment.
while in theory I agree, that is out of scope for this set of changes.
There was a problem hiding this comment.
It’d be clearer if they were called jdm_ntsc, export_ntsc, etc. but it should probably be in machine configuration and not an init function anyway.
angelosa
approved these changes
Nov 17, 2023
|
As I've mentioned before, the entire MD emulation is a relic of when it was
written at this point, so yeah, I agree with all points, but an
implementation based on current knowledge rather than one which will
regress end results is beyond my ability, and the rest is superficial
changes.
…On Fri, 17 Nov 2023, 17:05 Vas Crabb, ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/mame/sega/megaplay.cpp
<#11748 (comment)>:
> @@ -969,7 +969,8 @@ void mplay_state::init_megaplay()
m_ic36_ram = std::make_unique<uint16_t[]>(0x10000 / 2);
m_ic37_ram = std::make_unique<uint8_t[]>(0x10000);
- init_megadrij();
+ // use Export NTSC init, as MegaPlay was apparently only intended for export markets.
+ init_megadriv();
It’d be clearer if they were called jdm_ntsc, export_ntsc, etc. but it
should probably be in machine configuration and not an init function anyway.
—
Reply to this email directly, view it on GitHub
<#11748 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/BBR6GZMXK62KCEZFN4CNWQTYE6KMVAVCNFSM6AAAAAA7OAFCAGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTOMZXGQ4TKOJVGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.