upd933: rework irq to use a timer #11750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cuavas
reviewed
Nov 18, 2023
src/devices/sound/upd933.cpp
Outdated
Comment on lines
200
to
204
| if (m_irq_state != (m_cs & m_id & m_irq_pending)) | ||
| { | ||
| m_irq_state ^= 1; | ||
| m_irq_cb(m_irq_state); | ||
| } |
There was a problem hiding this comment.
If someone puts an unexpected value into m_irq_state (e.g. with the debugger or a Lua script, since they can access stuff registered for save states) this is going to behave really strangely.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From my still-in-progress CZ-1 driver, this mostly just changes interrupt generation to ensure accurate timing. Also better handling of interrupt priority (probably) and a couple of other miscellaneous things for the aforementioned driver.