Revert "Revert "seibu/dynduke_v.cpp: Use single-pass sprite drawing. (#11758)"" #11764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this also broken? If no, why did you close it? |
Because it was opened as a draft PR with no description, suggesting it still wasn't tested, I missed the one changed line from the previous iteration, and I'm still incredibly frustrated with the experience when this had gone through two iterations but was still obviously broken. @cam900 should know these kinds of things shouldn't be opened until they're ready. |
|
Ok, it's not broken, and after yesterday's merge (implying approval of source code), and only 1 line added to fix it, it can be merged (that is, if it wasn't marked draft PR...) |
This PR includes fixing missing graphics, Tested and it might be working.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes fixing missing graphics, Tested and it might be working.