Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

heathkit/tlb.cpp: Fix on-screen menus for superset tlbc slot option #11771

Merged
merged 2 commits into from
Nov 22, 2023
Merged

heathkit/tlb.cpp: Fix on-screen menus for superset tlbc slot option #11771

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e54588a
tlb.cpp: Fix on-screen menus for superset tlbc slot option
mgarlanger Nov 21, 2023
29aa033
Use simplier set_video_attributes() call
mgarlanger Nov 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/mame/heathkit/tlb.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
- In 49/50 row mode, character descenders are cut off.
- Screen saver does not disable the screen
- With superset slot option
- Screen menus not working properly
- Screensaver freezes the screen instead of blanking the screen

****************************************************************************/
Expand Down Expand Up @@ -1117,6 +1116,9 @@ void heath_superset_tlb_device::device_add_mconfig(machine_config &config)
m_maincpu->set_addrmap(AS_PROGRAM, &heath_superset_tlb_device::mem_map);
m_maincpu->set_addrmap(AS_IO, &heath_superset_tlb_device::io_map);

// per line updates are needed for onscreen menu to display properly
m_screen->scanline().set([](int scanline) {});

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn’t it make more sense to do m_screen->set_video_attributes(VIDEO_UPDATE_SCANLINE); if what you’re trying to do is to get the screen to do partial updates for each scan line?

m_crtc->set_update_row_callback(FUNC(heath_superset_tlb_device::crtc_update_row));

// link up the serial port outputs to font chip.
Expand Down