Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tvochken.xml: Add TV Ocha-Ken barcode card parts #11773

Merged
merged 1 commit into from Dec 10, 2023

Conversation

qufb
Copy link
Contributor

@qufb qufb commented Nov 21, 2023

Added software list with barcode card artwork.

hash/tvochken.xml Outdated Show resolved Hide resolved
src/mame/layout/tvochken.lay Outdated Show resolved Hide resolved
@happppp
Copy link
Member

happppp commented Nov 22, 2023

For a console's internal ROM(s), the preferable place is the driver file.

@qufb
Copy link
Contributor Author

qufb commented Nov 22, 2023

For a console's internal ROM(s), the preferable place is the driver file.

Makes sense, reverted this change.

Just added a comment in case someone finds it odd to use a cart loader without a cart ROM.

@happppp
Copy link
Member

happppp commented Nov 22, 2023

Here's something similar. It's not emulated yet, but if it was then the MCU ROM would be in the driver file, and the barcode data somewhere else.
https://www.youtube.com/watch?v=aqWKku8RYdY

@einstein95
Copy link
Contributor

Just added a comment in case someone finds it odd to use a cart loader without a cart ROM.

I could swear there was a software list of barcodes for one device.

@wd40yasu
Copy link
Contributor

wd40yasu commented Nov 22, 2023 via email

@cuavas
Copy link
Member

cuavas commented Nov 22, 2023

@qufb can you fill me in on how this system works and point me at some pictures of it? I don’t have a clear picture of it in my head, and this will affect how the stuff will get hooked up.

Some initial questions:

  • Did the system come with a set of cards, or were they sold individually?
  • What do the cards look like? Can you post low-resolution versions of a couple here?
  • Are the cards logically a single “deck”, or are they more standalone?

@qufb
Copy link
Contributor Author

qufb commented Nov 22, 2023

You can find some screenshots and photos here, including of the cards: https://game.watch.impress.co.jp/docs/20050811/toy191.htm

These cards were sold with the system, and functionally are more standalone. A player can pick any of them without any particular order.

For layout interaction, it is sufficient to just cycle through cards. The currently shown card would be scanned with the corresponding input.

@cuavas
Copy link
Member

cuavas commented Dec 10, 2023

OK, I need to add a couple more script bindings for this. Can you please:

  • Back out the changes to the C++ code and layout, I’ll deal with that part later.
  • Change the software list to have a single item with one part per card.
  • You can set the name for each part to card1, card2, etc.
  • Use a <feature name="part_id" ... /> to give the display name for each card.
  • Use another <feature ... /> to store the barcode data for each card.

I can take care of the code changes to support it later.

@qufb qufb changed the title sega/sega_beena.cpp: Add TV Ocha-Ken barcode card rendering tvochken.xml: Add TV Ocha-Ken barcode card parts Dec 10, 2023
@qufb
Copy link
Contributor Author

qufb commented Dec 10, 2023

Updated. Are you considering some separate interface to load these parts? I left them with the same cart loader.

@cuavas
Copy link
Member

cuavas commented Dec 10, 2023

Updated. Are you considering some separate interface to load these parts? I left them with the same cart loader.

Yeah, it’s going to need its own implementation of device_image_interface. But if the software list gets in now, it’s easy enough for me to pick up the work to get it working when I get a chance.

@cuavas cuavas merged commit bb12bd5 into mamedev:master Dec 10, 2023
3 checks passed
Luigi30 pushed a commit to Luigi30/mame that referenced this pull request Dec 16, 2023
…mamedev#11773)

New software list items marked not working (tvochken.xml)
------------------------------------
TV to Ocha-Card: Ocha-Ken 'Ho' to Seikatsu
einstein95 pushed a commit to einstein95/mame that referenced this pull request Mar 2, 2024
…mamedev#11773)

New software list items marked not working (tvochken.xml)
------------------------------------
TV to Ocha-Card: Ocha-Ken 'Ho' to Seikatsu
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants