heathkit/tlb.cpp: Use memory bank for imaginator I-100 ROM #11778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cuavas
reviewed
Nov 24, 2023
Comment on lines
1575
to
1578
| void heath_imaginator_tlb_device::tap_6000h() | ||
| { | ||
| if (m_mem_map != 0) | ||
| { | ||
| m_mem_map = 0; | ||
| m_mem_view.select(m_mem_map); | ||
| } | ||
| m_mem_bank->set_entry(0); | ||
| } |
There was a problem hiding this comment.
As far as I can tell, the only way for it to flip back to entry 1 is on reset, so you could make it uninstall the tap after the first time it’s hit to make it a bit more efficient.
There was a problem hiding this comment.
@cuavas How do you uninstall a tap? I looked for a method that would do it and didn't see anything.
There was a problem hiding this comment.
With .remove(): 706cc60
You can find a fair few uses of read/write taps around the source tree if you grep for them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change from memory_view to memory bank for the Imaginator I-100 ROM.