PXA255/39in1: Improve register mapping, fix EEPROM readback. #11780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 25, 2023 19:25
* Eliminated custom header in favor of scoped enums. * Eliminated double-dispatch switch/case in handlers, in favor of individual register handlers. * Reworked GPIO handling for correctness. - 39in1: Fixed GPIO hookup, now boots on its own. [Ryan Holtz]
cuavas
reviewed
Nov 27, 2023
There was a problem hiding this comment.
This looks pretty straightforward, and makes the code take advantage of more quality-of-life stuff we get these days.
I noticed one read handler missing a check for disabled side effects.
Another thing to think about, although probably better to do separately, is adding side effect checks before logging in read handlers to avoid log spam when debugger memory windows are open. But it isn’t critical since it isn’t a regression and logging is disabled at compile time by default.
einstein95
pushed a commit
to einstein95/mame
that referenced
this pull request
Mar 2, 2024
…1780) [Ryan Holtz] * Implemented free-running timer. * Eliminated internal header in favor of scoped enums. * Eliminated double-dispatch switch/case in handlers, in favor of individual register handlers. * Reworked GPIO handling for correctness. -misc/39in1.cpp: Fixed GPIO hookup, now boots on its own. [Ryan Holtz]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-pxa255: General cleanups. [Ryan Holtz]
-39in1: Fixed GPIO hookup, now boots on its own. [Ryan Holtz]