konami/ksys573: Add Dance Dance Revolution (GC845 VER. JAB)

[987123879113]

ROM dump thanks to tweak! and Caldenza. Track 23 of 845jab02 had 2 places where the audio dropped so Taro made a dump of his own CD to replace the old dump.

Additionally, CDDA audio volume should work properly again now. DDR will read in the CD audio control page, modify what it needs, then send it back on boot. In a refactor back in Sept the code was rewritten to use ptr instead of fixed offsets in the data buffer so all pages could be sent back when requested, but it unintentionally changed the layout of the page data so the volumes in older DDR games sounded really unbalanced when it tried to set the output gain for the CDDA channels to non-sense values.

[cuavas]

I’ve been saying this so many times lately, but can everyone please stop doing their best to trip up scripts for scraping new/promoted systems, etc.? Just use the format seen in whatsnew text files. Otherwise there’s a good chance the person merging in won’t edit it. There were numerous commits in 0.261 that wouldn’t scrape properly, and that slows me down when I’ve got three days tops to get the release notes sorted out, as well as doing some basic smoke testing for the release.

There are three things here that will mess with scripts:

• The scripts expect a line of hyphens to introduce a list. The commit here uses equals signs.
• The scripts look for list headings starting with “New ” for lists of newly added systems or software. This does that for a list of promotions.
• This is a promoted clone, and the list heading lacks the word “clone” or “clones” which means I need to double-check the discrepancy.

I make an effort to sort this stuff out every month, but the more stuff I have to manually reconcile, the higher my workload in what’s already a very stressful week, and the more chance I’ll make mistakes.

[angelosa]

Part of it can be mitigated by changing the default message for squash merging, I'm pretty sure it's set to "Default message" which is not what we want here:
https://github.blog/changelog/2022-08-23-new-options-for-controlling-the-default-commit-message-when-merging-a-pull-request/
The other half would be that the title/description are well formed to begin with, and it looks painful because it looks it needs a CI action that reverts commits that doesn't adhere to what's defined in
https://github.com/mamedev/build/blob/master/whatsnew/whatsnew_template.txt
cfr.
https://stackoverflow.com/questions/74352636/how-to-lint-the-message-of-a-pull-request-merge-commit