kaneko/kan_pand.cpp: Use device_gfx_interface for gfx decoding behavior, use correct type for variables #11793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ior, use correct type for variables
cam900
changed the title
* Use standard write line signature for set_clear_bitmap. * Don't split member initialisation across files.
cuavas
reviewed
Nov 29, 2023
src/mame/kaneko/kan_pand.h
Outdated
Comment on lines
39
to
46
| void set_clear_bitmap( int clear ); | ||
| void set_clear_bitmap( bool clear ); |
There was a problem hiding this comment.
This should probably stay as int so it uses the standard devcb write line signature in case anything tries to hook it up that way.
Luigi30
pushed a commit
to Luigi30/mame
that referenced
this pull request
Dec 16, 2023
…amedev#11793) -kaneko/airbustr.cpp: Fixed offset of CALC1 chip in devram.
einstein95
pushed a commit
to einstein95/mame
that referenced
this pull request
Mar 2, 2024
…amedev#11793) -kaneko/airbustr.cpp: Fixed offset of CALC1 chip in devram.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kaneko/airbustr.cpp: Fix out of range issue