seibu/sei021x_sei0220_spr.cpp: Device-fied SEI0210/SEI0211/SEI0220 sprite emulation #11802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…I0220 sprite emulation banprestoms.cpp: Use single-pass sprite drawing bloodbro.cpp: Sepatate class via hardware configurations dcon.cpp: Fix sprite coordinate format goodejan.cpp: Fix comment sengokmj.cpp: Use single-pass sprite drawing
|
I haven't looked at the code, but let me comment that you chose a very long filename. Normally with a device family, you name the file after the base device. |
|
Agree with hap. Sometimes we also use a placeholder, so it could also potentially be |
…20 sprite emulation
cam900
changed the title
cuavas
reviewed
Dec 2, 2023
Luigi30
pushed a commit
to Luigi30/mame
that referenced
this pull request
Dec 16, 2023
…prite chip emulation. (mamedev#11802) * seibu/banprestoms.cpp, seibu/sengokumj.cpp: Use single-pass sprite drawing. * seibu/bloodbro.cpp: Split driver state classes for different hardware configurations. * seibu/dcon.cpp: Fixed sprite coordinate format.
einstein95
pushed a commit
to einstein95/mame
that referenced
this pull request
Mar 2, 2024
…prite chip emulation. (mamedev#11802) * seibu/banprestoms.cpp, seibu/sengokumj.cpp: Use single-pass sprite drawing. * seibu/bloodbro.cpp: Split driver state classes for different hardware configurations. * seibu/dcon.cpp: Fixed sprite coordinate format.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
seibu/banprestoms.cpp: Use single-pass sprite drawing
seibu/bloodbro.cpp: Separate class via hardware configurations, Reduce duplications
seibu/dcon.cpp: Fix sprite coordinate format, fix GFX ROM region naming
seibu/goodejan.cpp: Fix comment
seibu/sengokmj.cpp: Use single-pass sprite drawing