video/mc6845.cpp: Fix hang in ma7551t related to mc6845 #11803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Luigi30
pushed a commit
to Luigi30/mame
that referenced
this pull request
Dec 16, 2023
…set. (mamedev#11803) Fixes hang in ma7551t.
einstein95
pushed a commit
to einstein95/mame
that referenced
this pull request
Mar 2, 2024
…set. (mamedev#11803) Fixes hang in ma7551t.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in #11756 caused the ma7551t to hard lock up. With the updated code, the system seems to be overloaded with
handle_line_timer()calls and initialization does not complete, even though the boolm_has_valid_parametersis false. This change, does not enable the line timer untilm_has_valid_parametersbecomes true, this allows the system to properly initialize. And for systems that has valid parameters, the enabling is done inrecompute_parameters().