-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mame/bfm: Implement Bell Fruit 96x8 dot matrix display for Scorpion 5. #11805
Conversation
"If the Scorpion 5 driver is ever progressed the correct display will have to be loaded for each game" are the custom characters not uploaded by the game? Ideally it would be good to see all these display drivers decapped to see if they're MCUs, or at the very least contain a ROM with these character tables in them. |
Yes, the custom or UDF are uploaded by each game. What I meant was some games use this 96 * 8 dot matrix display and others use a 16 * 5*7 dot matrix display which are obviously visually quite different
The display emulated here uses an ATMEGA8515, I don't know if that can be dumped ? |
src/mame/bfm/bfm_gu96x8m_k657c2.cpp
Outdated
@@ -0,0 +1,1010 @@ | |||
// license:BSD-3-Clause | |||
// copyright-holders: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do need this to list something for the copyright holder :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I can put my name there.
As this file was derived from bfm_bda.cpp by James Wallace do I need to do something to acknowledge that ?
|
||
case LOAD_LED_COLOUR: | ||
m_load_extra_data = LOAD_COMPLETE; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would be cleaner as a switch.
Replace if/else if/else if with switch statement. Modified copyright message
I think the copyright messages are probably wrong ? |
As far as I'm concerned, you don't need to consider this as from me, you've changed enough. The copyright is because the BDA HLE is actually a derivative of my BD1 code for Scorpion 2, as we didn't have the dot matrix data in a usable form. David may well have changed it as part of the Scorpion 4 hookup, but feel free to assign yourself rather than me on this. |
mamedev#11805) * New driver for BFG 96x8 dot matrix vfd * Add 96x8 dot matrix vfd to Bell Fruit Scorp5
This implements the Bell Fruit GU96X8M-K629C3 96 * 8 VFD with led backlight.
ATM I've simply replaced the use of the BDA display which had 16 5*7 dot matrix digits with this new display driver.
If the Scorpion 5 driver is ever progressed the correct display will have to be loaded for each game.