Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mame/bfm: Implement Bell Fruit 96x8 dot matrix display for Scorpion 5. #11805

Merged
merged 4 commits into from
Jan 23, 2024

Conversation

blueonesarefaster
Copy link
Contributor

This implements the Bell Fruit GU96X8M-K629C3 96 * 8 VFD with led backlight.

ATM I've simply replaced the use of the BDA display which had 16 5*7 dot matrix digits with this new display driver.
If the Scorpion 5 driver is ever progressed the correct display will have to be loaded for each game.

@mamehaze
Copy link
Contributor

mamehaze commented Dec 4, 2023

"If the Scorpion 5 driver is ever progressed the correct display will have to be loaded for each game" are the custom characters not uploaded by the game?

Ideally it would be good to see all these display drivers decapped to see if they're MCUs, or at the very least contain a ROM with these character tables in them.

@blueonesarefaster
Copy link
Contributor Author

blueonesarefaster commented Dec 4, 2023

"If the Scorpion 5 driver is ever progressed the correct display will have to be loaded for each game" are the custom characters not uploaded by the game?

Yes, the custom or UDF are uploaded by each game. What I meant was some games use this 96 * 8 dot matrix display and others use a 16 * 5*7 dot matrix display which are obviously visually quite different

Ideally it would be good to see all these display drivers decapped to see if they're MCUs, or at the very least contain a ROM with these character tables in them.

The display emulated here uses an ATMEGA8515, I don't know if that can be dumped ?
I don't know what the previous dot matrix display used.

@@ -0,0 +1,1010 @@
// license:BSD-3-Clause
// copyright-holders:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do need this to list something for the copyright holder :-)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I can put my name there.
As this file was derived from bfm_bda.cpp by James Wallace do I need to do something to acknowledge that ?


case LOAD_LED_COLOUR:
m_load_extra_data = LOAD_COMPLETE;

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be cleaner as a switch.

blueonesarefaster and others added 2 commits January 5, 2024 11:23
Replace if/else if/else if with switch statement.
Modified copyright message
@blueonesarefaster
Copy link
Contributor Author

I think the copyright messages are probably wrong ?
Looking at bfm_bda which this was derived from the header says David Haywood and the source says James Wallace.
I've restored the messages in this PR to match the files it was derived from and added my name to the source.
Hopefully someone can correct me if I'm wrong

@james-wallace-ghub
Copy link
Member

As far as I'm concerned, you don't need to consider this as from me, you've changed enough. The copyright is because the BDA HLE is actually a derivative of my BD1 code for Scorpion 2, as we didn't have the dot matrix data in a usable form. David may well have changed it as part of the Scorpion 4 hookup, but feel free to assign yourself rather than me on this.

@rb6502 rb6502 changed the title Implement Bell Fruit 96x8 dot matrix display for Scorpion 5. mame/bfm: Implement Bell Fruit 96x8 dot matrix display for Scorpion 5. Jan 23, 2024
@rb6502 rb6502 merged commit a42a71d into mamedev:master Jan 23, 2024
3 of 5 checks passed
MooglyGuy pushed a commit to MooglyGuy/mame that referenced this pull request Jan 28, 2024
mamedev#11805)

* New driver for BFG 96x8 dot matrix vfd
* Add 96x8 dot matrix vfd to Bell Fruit Scorp5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants