taito/taito_f3_v.cpp: major rewrite #11811

y-ack · 2023-12-02T22:30:29Z

simplify sprite logic, eliminate game-specific kludge
simplify line ram access
simplify draw loop
fix sprite bankswitch - riding fight sprites now 60fps
more accurate sprite scaling
x mosaic effect (ring rage, riding fight, command war, moriguchi hiroko no quiz de hyuu!hyuu!)
screen raw parameters based on others' measurements and mosaic quirk
identify mosaic flags for sprites and pivot layer
re-derive blending rules (riding fight, space invaders dx, elevator action returns, recalhorn, gekirindan, bubble memories, cleopatra fortune, puchi carat, land maker)
identify sprite and pivot blend value select (arabian magic, grid seeker)
line ram alternate subsections (bubble memories)
sprite framebuffer unblit disable (sprite trails) (darius gaiden)
emulate blending priority conflict (darius gaiden, bubble memories, grid seeker)

MT#8697, MT#2527, MT#1922, MT#26, MT#2733, MT#3741, MT#2002, MT#1907, MT#7321, MT#2097, MT#1924, MT#1923, MT#8827, GH #10033

Systems promoted to working

Moriguchi Hiroko no Quiz de Hyuu!Hyuu! [ywy, 12Me21]

Co-authored-by: 12Me21 <12Me21.mc@gmail.com>

* nicer sprite data access * clean up bitmasks, x/y position reading * simplify logic, eliminate per-game hack "dariusg kludge"

y-ack · 2023-12-02T22:31:23Z

…e lag correct now ?

y-ack · 2024-04-05T02:56:26Z

Regression for Elevator Action Returns, the airplane section is broken now

hi @TheCoolPup, thanks for finding this. it looks like playfields and sprites get disabled when set to the 'wrong' opaque mode.

y-ack · 2024-04-05T03:21:19Z

Before anything else, please clean up your changes to match the existing code in the files you’re working on.

Please Allman formatting consistently (opening braces on their own lines).

@cuavas we've rewritten 90% of the code already, it's easier at this point to switch to (consistently) k&r.
my understanding is that no one else has seriously worked on the driver in years, i hope it's ok?

happppp · 2024-04-05T11:44:23Z

src/mame/taito/taito_f3.h

+		u16 maybe_sync_reg{0};
+		bool no_opaque_dest{false};
+		// 6200
+		u8 blend[4]{0}; // less 0 - 8 more


FYI initializing arrays like this, it will only initialize the 1st index, and fill the rest with 0. Best use {} like you did elsewhere. Same result in this specific case but less misleading.

see:
int m_array[4] { 1 };
for (int i = 0; i < 4 ; i++) printf("%d ",m_array[i]);
-> 1 0 0 0

thanks; fixed.

src/mame/taito/taito_f3.cpp

happppp · 2024-04-05T11:47:48Z

If it is as you say and 90% of the file is yours (refactors don't count), then yes source code style choice is yours. Also, good time to include yourself to copyright holders.

cuavas · 2024-04-05T13:45:36Z

I don’t want it to end up with different formatting for the different Taito F3 source files, though. There’s taito_f3.cpp as well.

y-ack · 2024-04-05T15:12:58Z

thanks for the comments. i agree that having different styles across the taito f3 files should be avoided.
taito_f3.cpp has only 4 functions that would need reformatting.
we hadn't touched it yet because there is so much to clean up there* (and heavily mame-specific idioms that require finding modern driver examples) that it seemed like the increased scope warranted focusing on in a separate PR. this one was supposed to address the video rendering primarily.

[*] for example:

the cpu clocks are wrong (as noted elsewhere in the file, it's 15.23809MHz, not 16)
we need to do more hardware testing to figure out how the interrupts are generated (there seems to be an hblank interrupt which not all games enable)
tile decoding wants refactoring?
repetitive init routines for almost all sets feels really bad (though maybe that's just necessary and normal for mame?)

TheCoolPup · 2024-04-07T15:29:38Z

Forgot to take screenshots but two other bugs i noticed is that in stage 4 when you are underground when you go through a subway car it doesn’t show you in it, also when you stop the missile at the end of the final stage it’s supposed to fade to white but instead it just turns black until the credits start

y-ack · 2024-04-07T20:45:03Z

in stage 4 when you are underground when you go through a subway car it doesn’t show you in it, also when you stop the missile at the end of the final stage it’s supposed to fade to white but instead it just turns black until the credits start

@TheCoolPup: the first one was the same bug as before; the second is the 'background palette' effect (so probably not a regression). both should be fixed in the latest commit.

y-ack · 2024-04-09T22:09:46Z

if the brace formatting not matching allman in mame core really is the blocking issue here, i will change it, but i push back in the interest of reducing friction for my co-contributor and i to continue working on the driver comfortably and maintain pace, not from a place of disrespect.

angelosa · 2024-04-10T00:10:39Z

The alternative would be "go to the other end and use K&R everywhere in these files, as long as it's consistent".

12Me21 · 2024-04-10T00:28:52Z

The alternative would be "go to the other end and use K&R everywhere in these files, as long as it's consistent".

she preemptively tentatively did that in 37ad667 and fce4bd9

angelosa · 2024-04-10T11:27:42Z

imo taito_f3_v.cpp will ultimately require a split into device(s) so it makes sense to have that with whatever style you prefer.
As for regular taito_f3.cpp :

f3_coin_r/f3_control_r/_w/f3_analog_r all belongs to TC0640FIO, which we already have a core of;
sound_reset_0_w/sound_reset_1_w can clearly be expressed as lambda nowadays;
Not sure about that kirameki soundbank interaction, by face value I guess it can be removed by loading sample ROMs properly (while hoping the game has a sound test that covers those);
gfxdecode, set_raw etc. belongs to the video device, so original point stands;

All of this is non-blocking for the PR, and there are roughly two weeks for the next release.

y-ack · 2024-04-13T19:11:36Z

i think our roadmap from here is:

performance work (this is already done, but want to split into another pr to handle any contentiousness separately, and if this one is "approach readability to fix blending"), could be this cycle.
device-ify (and timings) (this might take a little longer given relative unfamiliarity, but it's something i've had in the back of my mind the whole time)
- maybe rework for partial screen updates at this time too
- the existing FIO device may need work
- not sure if we want to consider the FDP and FDA as separate units, since as far as we can tell the FDA would just be a single function (color lookup/blending) and it's not known what the inputs to that look like outside of the context of the FDP.
- have to consider seoul symphony bootleg board in this?
- kirameki sound banking - we don't have the cart pcb and would like to take a look at it first to make sure, but this probably really is banking.
miscellaneous fixes: playfield scaling/scroll correctness (ridingf/scfinals etc.), palette interpretation, secret third way to generate shadows (rayforce/gseeker), sprite ram write timing(?) (scfinals)

dinkc64 · 2024-04-25T12:58:46Z

y-ack, I missed this 2 weeks ago, but, seriously: congrats y-ack & 12Me21!
What an awesome feat! :)

CPS42069 · 2024-05-07T16:02:21Z

the classic 5th boss explosion bug in Grid Seeker is still there, tested on latest nightly build.

12Me21 · 2024-05-07T16:43:53Z

the classic 5th boss explosion bug in Grid Seeker is still there, tested on latest nightly build.

yes, this is caused by the game writing sprites past the end of the sprite list and then never clearing them.
from hardware testing a few days ago, it seems like only the first ~864 sprites are rendered, rather than 1024 like was previously assumed.
(it should be fixed in a future pr, after we find the exact limit)

y-ack and others added 5 commits December 2, 2023 05:56

taito/taito_f3_v.cpp: major rewrite first commit - drawing SOMETHING

a68f0ed

Co-authored-by: 12Me21 <12Me21.mc@gmail.com>

taito/taito_f3_v.cpp: rewrite get_sprite_info (#3)

ba30f8f

* nicer sprite data access * clean up bitmasks, x/y position reading * simplify logic, eliminate per-game hack "dariusg kludge"

fix build, fix sprite y scale

44a5d94

basic playfield rendering

c4a000e

pacify clang warnings

567acf2

y-ack and others added 24 commits December 3, 2023 13:23

move layer draw to f3_state, switch pixel-based drawing to line-based

0cd76a1

clean up f3_drawgfx args (and fix sprite palette masking)

85a3f71

change sprite info / drawing units and rounding etc

bd0dcaf

goodnight,

65a2091

new sprite drawing

d3607de

oww

16afafa

wow

7d99704

aaaaaaaaaaaaaaaa!

cd58b94

closing my eyes..

504de7c

clean up sprite pixel loop

2013d0c

sprite framebuffer ind16

3b0603c

xor flip, units

5fc5a6b

vram rendering

e1830be

ignore first scaling value in effect offset integration

d329a10

a000 rowscroll!!

3e02d12

start displaying on line 24

b211241

clean up a little after 12's changes

481c10c

remove old code paths (⚠️)

b373ce0

const and other dubious cleanup

fe10908

5000 line clip !!!

662c47c

maybe

09dd506

persistent sprite bank, and trying to fix some timings. lightbr sprit…

1a5d48d

…e lag correct now ?

improve(?) screen timings

3f4897f

rounding when scaling sprites vertically

815f394

happppp reviewed Apr 5, 2024

View reviewed changes

src/mame/taito/taito_f3.cpp Show resolved Hide resolved

y-ack added 3 commits April 6, 2024 23:17

further f3 brace style consistency + other intentionality

fce4bd9

move type alias, remove unused render.h include

6eaa554

address constants review maybe, update clocks and interrupt comment too

29307fd

y-ack added 3 commits April 7, 2024 10:22

rename set_extend -> create_tilemaps for clarity

cc0336d

use bg palette (elvactr ending)

3b4b6e4

fill in some documentation unknowns

65fc384

y-ack added 4 commits April 7, 2024 16:06

update taito f3 copyright headers

7e82019

return ref self, pick up stray can-const and casts

215197f

un-auto 2 types and fix name typo in 7e82019

c5703da

update copyright in taito_f3.h too, last bit of notes updates for now

771b9ce

y-ack requested a review from cuavas April 9, 2024 22:09

angelosa merged commit 563b63f into mamedev:master Apr 23, 2024
5 checks passed

y-ack mentioned this pull request Apr 26, 2024

taito/taito_f3_v.cpp: regain performance after major rewrite #12312

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

taito/taito_f3_v.cpp: major rewrite #11811

taito/taito_f3_v.cpp: major rewrite #11811

y-ack commented Dec 2, 2023 •

edited

Loading

y-ack commented Dec 2, 2023 •

edited

Loading

y-ack commented Apr 5, 2024

y-ack commented Apr 5, 2024

happppp Apr 5, 2024 •

edited

Loading

y-ack Apr 7, 2024

happppp commented Apr 5, 2024 •

edited

Loading

cuavas commented Apr 5, 2024

y-ack commented Apr 5, 2024

TheCoolPup commented Apr 7, 2024

y-ack commented Apr 7, 2024

y-ack commented Apr 9, 2024

angelosa commented Apr 10, 2024 •

edited

Loading

12Me21 commented Apr 10, 2024

angelosa commented Apr 10, 2024

y-ack commented Apr 13, 2024

dinkc64 commented Apr 25, 2024

CPS42069 commented May 7, 2024

12Me21 commented May 7, 2024 •

edited

Loading

taito/taito_f3_v.cpp: major rewrite #11811

taito/taito_f3_v.cpp: major rewrite #11811

Conversation

y-ack commented Dec 2, 2023 • edited Loading

Systems promoted to working

y-ack commented Dec 2, 2023 • edited Loading

y-ack commented Apr 5, 2024

y-ack commented Apr 5, 2024

happppp Apr 5, 2024 • edited Loading

Choose a reason for hiding this comment

y-ack Apr 7, 2024

Choose a reason for hiding this comment

happppp commented Apr 5, 2024 • edited Loading

cuavas commented Apr 5, 2024

y-ack commented Apr 5, 2024

TheCoolPup commented Apr 7, 2024

y-ack commented Apr 7, 2024

y-ack commented Apr 9, 2024

angelosa commented Apr 10, 2024 • edited Loading

12Me21 commented Apr 10, 2024

angelosa commented Apr 10, 2024

y-ack commented Apr 13, 2024

dinkc64 commented Apr 25, 2024

CPS42069 commented May 7, 2024

12Me21 commented May 7, 2024 • edited Loading

y-ack commented Dec 2, 2023 •

edited

Loading

y-ack commented Dec 2, 2023 •

edited

Loading

happppp Apr 5, 2024 •

edited

Loading

happppp commented Apr 5, 2024 •

edited

Loading

angelosa commented Apr 10, 2024 •

edited

Loading

12Me21 commented May 7, 2024 •

edited

Loading