Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upd7220: Sync command should enable/disable the DE bit #11823

Merged
merged 1 commit into from Dec 10, 2023

Conversation

brijohn
Copy link
Contributor

@brijohn brijohn commented Dec 8, 2023

The SYNC command according to the upd7220 datasheet has a DE (Display Enable) on bit one of the command byte. This should be processed when receiving the command.

This fixes LOGO professor on the Epson QX-10. That program during boot uses BCTRL to disable the display and then slightly later issues a SYNC command to re-enable the display. Without this fix the disable is never turned back on.

@rb6502
Copy link
Contributor

rb6502 commented Dec 9, 2023

Hi! Have you done a sanity check with any of the other machines in MAME that use a uPD7220? This looks entirely reasonable, but we've been bitten recently by similar changes to other devices. As an example, if you have the software list sets, "mame dmv msdos211" should boot up MS-DOS on the NEC Decision Mate V. (As long as you see the text display the 7220 is working, that's all I'm asking for).

@brijohn
Copy link
Contributor Author

brijohn commented Dec 9, 2023

Hi! Have you done a sanity check with any of the other machines in MAME that use a uPD7220? This looks entirely reasonable, but we've been bitten recently by similar changes to other devices. As an example, if you have the software list sets, "mame dmv msdos211" should boot up MS-DOS on the NEC Decision Mate V. (As long as you see the text display the 7220 is working, that's all I'm asking for).

Yeah I did try some DMV software and text was being properly displayed.

@cracyc
Copy link
Member

cracyc commented Dec 9, 2023

Might be good to try the vt240 too which does an extensive test of the 7220 at start.

@brijohn
Copy link
Contributor Author

brijohn commented Dec 10, 2023

Might be good to try the vt240 too which does an extensive test of the 7220 at start.

Tested booting up a VT240 and the screen works correctly.

@rb6502 rb6502 merged commit 3a500bb into mamedev:master Dec 10, 2023
5 checks passed
Luigi30 pushed a commit to Luigi30/mame that referenced this pull request Dec 16, 2023
einstein95 pushed a commit to einstein95/mame that referenced this pull request Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants