heathkit/h89.cpp: Add dip switch settings for Ultimeth ROM #11839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cuavas
reviewed
Dec 14, 2023
src/mame/heathkit/h89.cpp
Outdated
| PORT_DIPSETTING( 0x0d, "?" ) | ||
| PORT_DIPSETTING( 0x0e, "?" ) | ||
| PORT_DIPSETTING( 0x0f, "? Magnolia 128K pseudo disk" ) | ||
| PORT_DIPNAME( 0x10, 0x00, "Unknown" ) PORT_DIPLOCATION("SW501:5") PORT_CONDITION("CONFIG", 0x3c, EQUALS, 0x18) |
There was a problem hiding this comment.
There’s a DEF_STR for “Unknown”.
There was a problem hiding this comment.
Also, you should still provide Off/On settings for unknown or unused DIP switches so people can twiddle them.
Luigi30
pushed a commit
to Luigi30/mame
that referenced
this pull request
Dec 16, 2023
einstein95
pushed a commit
to einstein95/mame
that referenced
this pull request
Mar 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dip switch settings are based some testing, and the fact that the Kres KMR-100 ROM was based on the Ultimeth ROM with some addition support for Kres hardware devices.