qbus device: DVK "MX" floppy controller #11840
Conversation
|
@shattered Are you going to clean up these issues? |
src/devices/bus/qbus/dvk_mx.cpp
Outdated
| flopi[i].id = i; | ||
| name[0] = '0' + i; | ||
| name[1] = 0; | ||
| floppy_connector *con = subdevice<floppy_connector>(name); |
There was a problem hiding this comment.
Please go for a required_device_array, it's rather nicer.
There was a problem hiding this comment.
Not sure how to use it here, tbh.
There was a problem hiding this comment.
You have a member like:
required_device_array<floppy_connector, 4> m_connectors;Initialise it like:
m_connectors(*this, "%u", 0U)And then you can just do like m_connectors[i]->whatever() and use it in place of literal tag string in the machine configuration function as well.
|
|
||
| uint16_t read(offs_t offset); | ||
| void write(offs_t offset, uint16_t data); | ||
|
|
There was a problem hiding this comment.
Looks like that fdc can't interrupt the main cpu. If it's the case there is a somewhat better structure than predict/commit (like the wd/upd/amiga do), it's catchup on access (like diskii/iwm/swim1-2). But it's good anyway.
There was a problem hiding this comment.
I have another floppy code in the works, will look into that.
No description provided.