heathkit/tlb.cpp: Reverse bits in font roms to avoid doing it on scanout #11842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cuavas
reviewed
Dec 16, 2023
src/mame/heathkit/tlb.cpp
Outdated
Comment on lines
219
to
222
| memory_region *region = device().memregion("chargen"); | ||
| int font_rom_size = (region != nullptr)? region->bytes() : 0; | ||
|
|
||
| for(int i = 0; i < font_rom_size; i++) |
There was a problem hiding this comment.
Since m_p_chargen is a required_region_ptr, you can’t get here if the memory region doesn’t exist. You can also call .length() on it to get the length in elements, and you don’t need to call .device() to get device_t members in a device_t implementation.
Luigi30
pushed a commit
to Luigi30/mame
that referenced
this pull request
Dec 16, 2023
einstein95
pushed a commit
to einstein95/mame
that referenced
this pull request
Mar 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reversing the bits during device_start() avoids having to do it for every scan line when using the imaginator slot device, since the font bits are reverse from the pixel layout and one would be need be reversed.
Reversing is also needed for the SigmaSoft IGC in this open PR - #11801 Depending on which PR is merged first, I will update the other PR to properly handle this.