heathkit/h89.cpp: Implement single-step hardware #11847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cuavas
reviewed
Dec 22, 2023
src/mame/heathkit/h89.cpp
Outdated
Comment on lines
210
to
216
| void h89_state::map_fetch(address_map &map) | ||
| { | ||
| map(0x0000, 0xffff).lr8(NAME([this](offs_t offset) | ||
| { | ||
| return m1_r(offset); | ||
| })); | ||
| } |
There was a problem hiding this comment.
This seems overly convoluted – why can’t use use map(0x0000, 0xffff).r(FUNC(h89_state::m1_r)); in the same way that e.g. src/mame/osborne/osborne1.cpp does?
src/mame/heathkit/h89.cpp
Outdated
Comment on lines
57
to
64
| // Single Step | ||
| #define LOG_SS (1U << 1) | ||
|
|
||
| #define VERBOSE ( LOG_SS ) | ||
| #include "logmacro.h" | ||
|
|
||
| #define LOGSS(...) LOGMASKED(LOG_SS, __VA_ARGS__) | ||
|
|
There was a problem hiding this comment.
This is all macro glue – it goes outside the anonymous namespace. Also, probably a good idea not to leave logging enabled here since it’s in a read handler and hence very hot.
src/mame/heathkit/h89.cpp
Outdated
Comment on lines
222
to
223
| if (m_single_step_enabled && !m_556b_latch) | ||
| { |
There was a problem hiding this comment.
Don’t forget to check !machine().side_effects_disabled() or this will cause chaos when debugger windows are open.
einstein95
pushed a commit
to einstein95/mame
that referenced
this pull request
Mar 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes implement the single-step hardware functionality in the H89. This is based the manual, and an h89 diagnostic program. It is now passing the tests:
