taito/gladiatr.cpp: Use set_format for palette format, Minor cleanups #11859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove VIDEO_START_MEMBER and MACHINE_RESET_MEMBER, use video_start() and machine_reset() overrides instead. Reduce runtime tag lookups Rename gfx regions for consistent.
cuavas
reviewed
Dec 20, 2023
src/mame/taito/gladiatr.cpp
Outdated
| membank("bank2")->set_entry((data & 0x40) ? 1 : 0); | ||
| m_adpcmbank->set_entry(BIT(data, 6) ? 1 : 0); |
There was a problem hiding this comment.
This is somewhat redundant now – if you’re using the BIT helper, you can just do m_adpcmbank->set_entry(BIT(data, 6));
src/mame/taito/gladiatr.cpp
Outdated
| //membank("bank2")->set_entry((data & 0x40) ? 1 : 0); | ||
| //m_adpcmbank->set_entry(BIT(data, 6) ? 1 : 0); |
There was a problem hiding this comment.
Same here – the BIT helper extracts the bit so it will produce 1 or 0 anyway.
einstein95
pushed a commit
to einstein95/mame
that referenced
this pull request
Mar 2, 2024
…amedev#11859) * Removed VIDEO_START_MEMBER and MACHINE_RESET_MEMBER (override virtual member functions instead). * Reduced run-time tag lookups. * Made graphics region tags more descriptive.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove VIDEO_START_MEMBER and MACHINE_RESET_MEMBER, use video_start() and machine_reset() overrides instead. Reduce runtime tag lookups
Rename gfx regions for consistent.