Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

igs/goldstar.cpp: Added missing PROM and PLDs for 'hamhouse' [Taksangs] #11861

Merged
merged 2 commits into from Dec 22, 2023

Conversation

clawgrip
Copy link
Contributor

@clawgrip clawgrip commented Dec 21, 2023

Redumped all the ROMs with a different programmer, and found out that U24 is bitrotten (replaced the current dump with the best one we got, marking it as BAD_DUMP).

Also recorded a video from the real PCB: https://youtu.be/qiSw044Twdc

Redumped all the ROMs with a different programmer, and found out that U24 is bitrotten (replaced the current dump with the best one we got, marking it as BAD_DUMP).

Marked the game as MACHINE_WRONG_COLORS (see https://youtu.be/qiSw044Twdc)
@Osso13
Copy link
Member

Osso13 commented Dec 21, 2023

TBH it seems to me the colors are pretty much spot on in MAME after Ioannis' fixes:
0002
0000

@clawgrip
Copy link
Contributor Author

You mean using MACHINE_IMPERFECT_COLORS instead or remove any COLORS flag?

Thx!

@clawgrip clawgrip changed the title igs/goldstar.cpp: Added missing PROM and PLDs for 'hamhouse' igs/goldstar.cpp: Added missing PROM and PLDs for 'hamhouse' [Taksangs] Dec 21, 2023
@Osso13
Copy link
Member

Osso13 commented Dec 22, 2023

My attention to detail isn't really so good to make a call about this, but looking at this captures from the YouTube link you posted they seem pretty similar to the snaps I took from current MAME and posted above
immagine
immagine
I probably wouldn't add any flag, honestly.

@clawgrip
Copy link
Contributor Author

Fixed, thanks a lot!!!!

@cuavas cuavas merged commit 5a4d3ee into mamedev:master Dec 22, 2023
5 checks passed
@clawgrip clawgrip deleted the patch-14 branch December 22, 2023 13:18
einstein95 pushed a commit to einstein95/mame that referenced this pull request Mar 2, 2024
… [Taksangs]

* Added dumps for PROM at U39 and PLDs at U15 and U35.
* Re-dumped graphics ROM at U24 and marked as a bad dump (appears to be suffering bit rot).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants